Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set host network and tolerations for networking extension calico #471

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow to set host network and tolerations for networking extension calico #471

wants to merge 2 commits into from

Conversation

ScheererJ
Copy link
Member

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:

Allow to set host network and tolerations for networking extension calico.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Host network and tolerations can now be specified as helm values for the networking calico extension.

@ScheererJ ScheererJ requested review from a team as code owners August 20, 2024 14:38
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension labels Aug 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 20, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Aug 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 20, 2024
@ScheererJ ScheererJ force-pushed the enhancement/allow-host-network-and-tolerations branch from cde2e3b to b61df4d Compare August 20, 2024 14:47
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 20, 2024
@ScheererJ ScheererJ marked this pull request as draft August 21, 2024 06:55
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Oct 31, 2024

@ScheererJ: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-networking-calico-check-renovate-config b61df4d link true /test pull-gardener-extension-networking-calico-check-renovate-config

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Nov 4, 2024
@gardener-robot
Copy link

@ScheererJ You need rebase this pull request with latest master branch. Please check.

@rfranzke rfranzke added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 3, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 3, 2024
@rfranzke rfranzke force-pushed the enhancement/allow-host-network-and-tolerations branch from 05a09c6 to c7e96d9 Compare December 3, 2024 16:38
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScheererJ @gardener-robot @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3